[
https://issues.apache.org/jira/browse/S2GRAPH-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095981#comment-15095981
]
ASF GitHub Bot commented on S2GRAPH-21:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/7
[S2GRAPH-21] Change PostProcessBenchmarkSpec not to store and fetch test
data from storage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-21
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 2d4472048eecca28304e1fbc51ea9a81b2c22fe4
Author: SteamShon <[email protected]>
Date: 2016-01-07T03:54:34Z
S2GRAPH-21: remove re-create service/label on setup of
PostProcessBenchmarkSpec
----
> Change PostProcessBenchmarkSpec not to store and fetch test data from storage
> -----------------------------------------------------------------------------
>
> Key: S2GRAPH-21
> URL: https://issues.apache.org/jira/browse/S2GRAPH-21
> Project: S2Graph
> Issue Type: Test
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Trivial
> Labels: newbie, test
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> What PostProcessBenchmarkSpec supposed to do is testing performance of
> methods on PostProcess.
> Currently, this spec does following on setup phase.
> # delete and re-create test Service
> # delete and re-create test Label
> # insert test data into HBase
> also to run PostProcess`s method, it actually fetch inserted data from setup
> phase.
> I suggest not create test Label and insert test data entirely.
> instead we can create QueryRequest, QueryResult, QueryRequestWithResult
> classes without actually store test data.
> I think by using mocked edges
> # we can run this test without need for DBMS and HBase so we can concentrate
> on PostProcess logic`s performance only.
> # more flexible and fast test can be possible with regard to number of edges
> in QueryResult.
> In general, I think there should be no dependency on RDBMS + HBase for
> benchmark specs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
