[
https://issues.apache.org/jira/browse/S2GRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153855#comment-15153855
]
ASF GitHub Bot commented on S2GRAPH-36:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/19
[S2GRAPH-36]: Provide Blocking API for Edge/Vertex operations.
This PR contains following changes.
+ add withWait on incrementCounts/mutateEdgesBulk
+ move logics for deleteAll into s2core from rest project.
+ bug fix for ignoring isAsync flag on label for deleteAll.
+ change kafka message for deleteAll.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-36
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 0a9cdac52bcb8bf818203d0ce9704231635a61ed
Author: DO YUNG YOON <[email protected]>
Date: 2016-02-19T07:30:41Z
S2GRAPH-36 Provide Blocking API for Edge/Vertex operations.
----
> Provide Blocking API for Edge/Vertex operations.
> ------------------------------------------------
>
> Key: S2GRAPH-36
> URL: https://issues.apache.org/jira/browse/S2GRAPH-36
> Project: S2Graph
> Issue Type: New Feature
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Labels: feature
>
> There is no blocking API for edge/vertex operations such as
> Insert/Delete/Update/Increment/IncrementCount and bulk.
> When client want to get ack of their operations, it is necessary to provide
> blocking APIs. currently there is "withWait" parameter to control this
> behavior and we are not actually providing rest API for this option.
> I think we must provide blocking API so user can get ack for their operation
> so they can handle failure on their request.
> Since we have primitive built(we only use these in test cases so far), I
> think it would be easy to provide blocking API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
