[
https://issues.apache.org/jira/browse/S2GRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153889#comment-15153889
]
ASF GitHub Bot commented on S2GRAPH-40:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/23
[S2GRAPH-40] PostProcess.toHashKey gives different hash key with same value
when edge's label schema version is different.
+ use toString rather hashCode on different version of InnerVal
+ v1 and v2 InnerVal use different bytes encoding scheme.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-40
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 542e890e335bb18e19a4a4588f4354f877e16a75
Author: DO YUNG YOON <[email protected]>
Date: 2016-02-19T08:09:55Z
S2GRAPH-40 PostProcess.toHashKey gives different hash key with same value
when edge's label schema version is different.
use toString of innerVal to deal with different bytes scheme between v1 and
v2.
----
> PostProcess.toHashKey gives different hash key with same value when edge's
> label schema version is different.
> -------------------------------------------------------------------------------------------------------------
>
> Key: S2GRAPH-40
> URL: https://issues.apache.org/jira/browse/S2GRAPH-40
> Project: S2Graph
> Issue Type: Bug
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Labels: bug, testcase
>
> since hashCode of InnerVal on v1, v2 is different, same innerVal with string
> value "a" gives different hash key if schema version is different.
> This cause problem when filterOut is given or exclude is specified on
> queryParam since they compare hash key on to field of Edge and this hash key
> is produced by innerVal.hashCode.
> I think we can bypass this problem by using .toString on innerVal at
> toHashKey.
> Also there is no test cases for this so it is necessary to add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
