[ 
https://issues.apache.org/jira/browse/S2GRAPH-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155193#comment-15155193
 ] 

DOYUNG YOON commented on S2GRAPH-32:
------------------------------------

providing only now will end up not using request cache since we build request 
cache based on query. 

ex) now - 3 day yield different ts value on every call per each millisecond. 
this make request cache valid only one millisecond even with larger cacheTTL 
value.

what we actually want is more rough restriction, like "end of day - 4 day" so 
at least durations that is larger than cacheTTL produce same timestamp.

so I am suggesting it would be better to provide "next_week", "next_day", 
"next_hour", "next_minute", "next_second"  so we can still use request cache 
even with custom variables. 

better approach could be evaluating custom function on this, but I think 
"next_xxx" is easy to implement for now. what you guys think?

> Support variable such as now, day, hour on query.
> -------------------------------------------------
>
>                 Key: S2GRAPH-32
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-32
>             Project: S2Graph
>          Issue Type: New Feature
>            Reporter: DOYUNG YOON
>            Assignee: Daewon Jeong
>            Priority: Minor
>              Labels: feature
>
> In some cases, It is frequent to test with different value for time related 
> values on query with Experiments.
> ex) {noformat} "duration": {"from": 1454425200000, "to": 1454511600000} 
> {noformat}
> currently above changes require client to change request query body itself. 
> it would be great to support something like this.
> ex) {noformat} "duration": {"from": "${-1 day}", "to": "${now}"} {noformat} 
> benefit of this support is not requiring client to change their query so more 
> flexibility for A/B testing with experiment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to