[
https://issues.apache.org/jira/browse/S2GRAPH-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158600#comment-15158600
]
ASF GitHub Bot commented on S2GRAPH-44:
---------------------------------------
Github user daewon commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/28#issuecomment-187613799
+1
> Provide cache for WhereParser on query.
> ---------------------------------------
>
> Key: S2GRAPH-44
> URL: https://issues.apache.org/jira/browse/S2GRAPH-44
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Labels: Cache, Performance
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently, we are building WhereParser on every request and scala parser
> combinator is notorious for it's slow performance. Actually we don't have to
> build WhereParser on every request.
> WhereParser is dependent only on Label and where clause string. so I think it
> is better to provide parser cache with following key. note that Where class
> do not contain actual data, but expect caller to provide edge to check if
> given edge should be included or not.
> Key: labelName + where clause string.
> Value: Where class that hold structure for filtering.
> I think this can be important performance improvement and easy to implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
