[ 
https://issues.apache.org/jira/browse/S2GRAPH-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232063#comment-15232063
 ] 

ASF GitHub Bot commented on S2GRAPH-1:
--------------------------------------

GitHub user HyunsungJo opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/46

    [S2GRAPH-1] Feature/add redis storage

    Attempt of @HyunsungJo and @wishoping to integrate 
[S2Graph](https://github.com/apache/incubator-s2graph) with 
[Redis](https://github.com/antirez/redis).
    
    1. Have a Redis instance (or cluster) ready.
    2. Edit ```s2core/src/main/resources/reference.conf``` to have Redis 
configurations:
      ```
      s2graph.storage.backend=redis
    
      redis.storage=["localhost:6379"]
      ```
    3. Finally, run ```activator redis:test```!!


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyunsungJo/incubator-s2graph 
feature/add_redis_storage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 85e8561b839171cadb1b8f570c21d7d22976ebb7
Author: jojo <[email protected]>
Date:   2016-03-17T10:16:26Z

    merge redis storage

commit ccb7ce0f204252ab288b0b66ca85e2b40fa50fb9
Author: jojo <[email protected]>
Date:   2016-03-17T10:24:49Z

    merge redis storage

commit eff273b366d4d1a5311380ab8ae46ac4927a5fb8
Author: Junki Kim <[email protected]>
Date:   2016-03-21T00:50:10Z

    WIP add test only method

commit 2186b895e9509e2b76404c623cd0bd2138eb8a73
Author: Junki Kim <[email protected]>
Date:   2016-03-21T01:10:04Z

    WIP temporary disable kafka enqueue when too much retried

commit f597976e8da3360190d7669bf6786907adaf2c55
Author: Junki Kim <[email protected]>
Date:   2016-03-21T04:38:15Z

    WIP fix bug for future relaying lost problem

commit ad8627865b84cf6f40627055f47b8ef054358493
Author: jojo <[email protected]>
Date:   2016-03-23T00:35:27Z

    fix interval bug for redis

commit a900e8b8534fba8d76a64b59e531a0bc811263c6
Author: jojo <[email protected]>
Date:   2016-03-23T00:36:09Z

    enhance tests to support multiple versions + storages

commit d98c42d798ab3329b959c197ba7a1dbfcda33be7
Author: jojo <[email protected]>
Date:   2016-03-23T06:51:03Z

    refactor tests

commit 96735c5c78f19047992e24f17b5fb87e4af85f5c
Author: jojo <[email protected]>
Date:   2016-03-25T02:36:01Z

    change init locations for EdgeTest and WhereParserTest

commit f878620c7b87dcb66088c45120c0d61a12bd47b0
Author: jojo <[email protected]>
Date:   2016-03-28T02:35:09Z

    redis is now passing more TCs

commit 1b717b1fe5b1b881fa5baa79f8385f6ed2fad955
Author: jojo <[email protected]>
Date:   2016-03-28T10:23:16Z

    sample query test is now passing

commit 78852931fbc9d21f1288c9fd33d6f99597f91131
Author: jojo <[email protected]>
Date:   2016-03-29T05:30:37Z

    fix vertex and snapshot write bug

commit e76dd007dea617742c32fe1322cdc9087229cb96
Author: HyunsungJo <[email protected]>
Date:   2016-03-29T16:09:58Z

    debugging..

commit 967223568f95a151899536adf04383f2c09e1500
Author: jojo <[email protected]>
Date:   2016-03-31T09:33:19Z

    fix redis index edge delete bug

commit 66a32668af3bc585b4e80fa294ad80023d7e2c7b
Author: jojo <[email protected]>
Date:   2016-03-31T09:51:53Z

    fix weak label delete test; redis is passing all tests

commit 5c46c1f244772755b6266e4358d227b721653edb
Author: jojo <[email protected]>
Date:   2016-04-01T08:50:30Z

    add comment, minor refactoring in tests

commit 9f279f00794b238bb38c656fa8d88770f8ce453f
Author: jojo <[email protected]>
Date:   2016-04-04T03:19:09Z

    fix test bugs, default storage is hbase

commit a99656bf4fdc07d1124c291ce5173727e32b8247
Author: jojo <[email protected]>
Date:   2016-04-08T11:14:42Z

    set default configuration to redis

----


> Add Redis storage(Key/Value storage) engine for S2Graph
> -------------------------------------------------------
>
>                 Key: S2GRAPH-1
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-1
>             Project: S2Graph
>          Issue Type: Task
>            Reporter: Junki Kim
>            Assignee: Junki Kim
>              Labels: features
>
> h2. Background
> The purpose of S2Graph is to support all features of edge/vertex operations  
> with HBase. It is also to orchestrate with HBase’s key features such as scale 
> out / fault tolerant / highly available / etc. However, if there is no 
> engineer to support stably in managing Hadoop cluster, it is very difficult 
> to operate and maintain HBase and Hadoop clusters. Some companies, which 
> already have another key/value storages to serve their services, may want to 
> use S2Graph and also maintain their existing key/value storage environment. 
> With S2Graph’s persistent storage, we would have a better support in 
> operating another key/value storage. This is because S2Graph already has a 
> strong feature, which can support multiple storage engines.
> What is best key/value storage engine starting to support S2Graph?
> Can companies maintain their existing key/value storage engine and use 
> S2Graph at the same time? Yes, they can.
> Most of companies already have cache layers using Redis or Memcache. It is ok 
> for the companies to start with one of these storages to support another 
> key/value storage engine. It is because Redis is already suitable to support 
> HA and fault tolerant features. Therefore, they do not need to replace this 
> existing key/value storage engine.
> h2. Requirements
> - Support S2Graph storage engine’s interface
> -- Insert/Delete/Increment/etc.
> -- Query
> - Support serializer/deserializer to make edge/vertex data suit to key/value 
> storage’s schema ( e.g. byte array encoding/decoding )
> - Support idempotent feature (this is a similar feature to S2Graph)
> - Design saving schema for edge(IndexEdge, SnapshotEdge) / vertex
> - Support query builder for S2Graph’s getEdges syntax
> - etc.
> I would like to invite everyone to openly discuss about this. I will also 
> make a to-do list before I carry this issue in depth. Your feedback is 
> appreciated :)
> P.S.
> I couldn't fill some information about this issue, e.g. affected version, fix 
> version, component, etc. Please help me to fill out these mandatory fields. 
> In addition, this issue is umbrella issue for real subsequent tasks, so I 
> would like to make this epic issue. Can anyone help me out? I am new to 
> create apache jira issue :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to