[
https://issues.apache.org/jira/browse/S2GRAPH-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245270#comment-15245270
]
ASF GitHub Bot commented on S2GRAPH-62:
---------------------------------------
Github user SteamShon commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/45#discussion_r60018849
--- Diff: s2core/src/test/scala/org/apache/s2graph/core/CommonTest.scala ---
@@ -0,0 +1,13 @@
+package org.apache.s2graph.core
--- End diff --
we missed out Apacche license header here. please ```sbt runRatTask``` and
examine rat.out to check apache license header.
> Reinforce tests to cover multiple schema versions.
> --------------------------------------------------
>
> Key: S2GRAPH-62
> URL: https://issues.apache.org/jira/browse/S2GRAPH-62
> Project: S2Graph
> Issue Type: Test
> Reporter: Hyunsung Jo
> Priority: Minor
>
> The latest version of S2Graph has four schema versions (v1 through v4). Yet,
> most of the current test cases only cover one or two versions (usually v2 or
> v3). Each test case should run against all versions that support the feature
> being tested.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
