[
https://issues.apache.org/jira/browse/S2GRAPH-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305094#comment-15305094
]
ASF GitHub Bot commented on S2GRAPH-69:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/51
[S2GRAPH-69]: Change IndexEdge's props data type.
+ change props type of IndexEdge from Map[Byte, InnerValLike] to Map[Byte,
InnerValLikeWithTs]
+ change caller of IndexEdge's props data according to above type change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-69
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 360daba9da38659cc1e1fb9b75ee667265b8700c
Author: DO YUNG YOON <[email protected]>
Date: 2016-03-28T13:10:42Z
[S2GRAPH-66]: Optimize toEdge, IndexEdgeDeserializable using mutable Map.
use immutable.Map.newBuilder to build merged props.
commit c3c3ecf12a51c930a52944ab4bc5143575c9349b
Author: DO YUNG YOON <[email protected]>
Date: 2016-05-28T01:18:37Z
[S2GRAPH-69]: Change IndexEdge's props data type.
----
> Change IndexEdge's props data type.
> ------------------------------------
>
> Key: S2GRAPH-69
> URL: https://issues.apache.org/jira/browse/S2GRAPH-69
> Project: S2Graph
> Issue Type: Sub-task
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Labels: optimization, serde
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> User query traverse on IndexEdge, and current implemenation for deserialize
> bytes array into IndexEdge first(IndexEdgeDeserializable), then call
> IndexEdge#toEdge to create Edge class.
> I found out following parts copy data which is unnecessary.
> {noformat}
> props.map { case (k, v) => k -> InnerValLikeWithTs(v, version) }
> {noformat}
> This inefficiency exist because IndexEdge use Map[Byte, InnerValLike] and
> Edge use Map[Byte, InnerValLikeWithTs] as type of props value.
> It sounds like micro optimization but since this is called a lot, actually
> dependent on # fetched edges, I think improving this would create some
> changes on performance.
> To remove unnecessary copy, I am suggesting change type of IndexEdge's props
> same with Edge's props type Map[Byte, InnerValLikeWithTs].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
