[
https://issues.apache.org/jira/browse/S2GRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316420#comment-15316420
]
ASF GitHub Bot commented on S2GRAPH-63:
---------------------------------------
Github user daewon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/49
+1
> Condition on partition strong edges and weak edges on mutateEdges is wrong.
> ---------------------------------------------------------------------------
>
> Key: S2GRAPH-63
> URL: https://issues.apache.org/jira/browse/S2GRAPH-63
> Project: S2Graph
> Issue Type: Bug
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Labels: newbie, write
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Storage#mutateEdges use following condition to separate strong edges and weak
> edges.
> {noformat}
> val (strongEdges, weakEdges) =
> (edges.partition(e => e.label.consistencyLevel == "strong" || e.op ==
> GraphUtil.operations("insertBulk")))
> {noformat}
> I think current condition is wrong. the condition should be following.
> {noformat}
> val (strongEdges, weakEdges) =
> (edges.partition(e => e.label.consistencyLevel == "strong" && e.op !=
> GraphUtil.operations("insertBulk")
> {noformat}
> Because of above bug, insertBulk is not working as intended(not lookup
> snapshotEdge and just build and fire RPCs).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
