[
https://issues.apache.org/jira/browse/S2GRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320578#comment-15320578
]
ASF GitHub Bot commented on S2GRAPH-84:
---------------------------------------
Github user SteamShon commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/56#discussion_r66258428
--- Diff:
s2counter_loader/src/test/scala/org/apache/s2graph/counter/loader/stream/ExactCounterStreamingSpec.scala
---
@@ -1,217 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.s2graph.counter.loader.stream
-
-import org.apache.s2graph.core.{Management, GraphUtil}
-import org.apache.s2graph.core.mysqls.Label
-import org.apache.s2graph.counter.loader.counter.core.{CounterEtlItem,
CounterFunctions}
-import org.apache.s2graph.counter.loader.models.DefaultCounterModel
-import org.apache.s2graph.spark.config.S2ConfigFactory
-import org.apache.s2graph.spark.spark.HashMapParam
-import org.apache.spark.streaming.{Seconds, StreamingContext}
-import org.apache.spark.{SparkConf, SparkContext}
-import org.scalatest.{BeforeAndAfterAll, FlatSpec, Matchers}
-import play.api.libs.json.Json
-import CounterFunctions.HashMapAccumulable
-import s2.counter.core.TimedQualifier.IntervalUnit
-import s2.counter.core._
-import s2.counter.core.v2.{ExactStorageGraph, GraphOperation,
RankingStorageGraph}
-import s2.helper.CounterAdmin
-import s2.models.{Counter, DBModel}
-
-import scala.collection.mutable.{HashMap => MutableHashMap}
-import scala.concurrent.ExecutionContext.Implicits.global
-import scala.util.{Failure, Success}
-
-/**
- * Created by hsleep([email protected]) on 2015. 11. 19..
- */
-class ExactCounterStreamingSpec extends FlatSpec with Matchers with
BeforeAndAfterAll {
--- End diff --
Is it ok to just delete this specs? Just want to make sure.
> Test-case compilation error on `s2counter_loader` project
> ---------------------------------------------------------
>
> Key: S2GRAPH-84
> URL: https://issues.apache.org/jira/browse/S2GRAPH-84
> Project: S2Graph
> Issue Type: Task
> Reporter: Jaesang Kim
> Assignee: Jaesang Kim
> Priority: Trivial
>
> After resolving S2GRAPH-57 issue, package names are started with
> 'org.apache.s2graph'. But, 's2counter_loader' project's test-case was not
> changed. We need to reflect those changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
