[
https://issues.apache.org/jira/browse/S2GRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424128#comment-15424128
]
ASF GitHub Bot commented on S2GRAPH-93:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/65
[S2GRAPH-93]: Remove MySQL JDBC driver.
- remove mysql-connector-java from dependencies.
- change default metastore to use H2 instead of mysql.
- fix test cases to adopt H2 as default metastore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-93
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit e66753c3ac016dbd855975fd5ef66b9c464c16a6
Author: DO YUNG YOON <[email protected]>
Date: 2016-08-17T08:37:37Z
remove mysql-connector-java from dependencies.
fix minor bug when arise after change default database from mysql to h2.
----
> Remove MySQL JDBC driver.
> -------------------------
>
> Key: S2GRAPH-93
> URL: https://issues.apache.org/jira/browse/S2GRAPH-93
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Blocker
> Fix For: 0.1.0
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Since our default metastore is H2 already, there is no need to keep JDBC
> driver for MySQL(mysql-connector-java-5.1.39). I suggest remove this
> dependencies from source and provide extended instruction for users who want
> MySQL manually as metastore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
