Hi Do Yung,

thanks for casting a new release candidate. As I said during the previous
RC, I want to insist the very first release is very important milestone for
a podling.

Here my vote: -1 (binding)

I can't build from the sources given a missing dependency:

[info] Packaging
/home/wikier/tmp/s2graph/apache-s2graph-0.1.0-incubating/s2rest_netty/target/scala-2.11/s2rest_netty_2.11-0.1.0.jar
...
[info] Done packaging.
sbt.ResolveException: unresolved dependency:
org.scalaz.stream#scalaz-stream_2.11;0.7a: not found

For want I've check
http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.scalaz.stream%22%20AND%20a%3A%22scalaz-stream_2.11%22
only version 0.8.4a looks to be available from Maven Central.

I tried to build the RC sources in a clean environment: SBT 0.13.9, Scala
2.11.6, OpenJDK 1.8.0_91 64-Bit, Debian amd64

So far I've successfully checked:

* signatures and digests
* source releases file layouts
* matched git tags and commit ids
* incubator suffix and disclaimer, NOTICE and LICENSE files
* license headers,

Thanks for addressing all my comments to RC1 <https://s.apache.org/oarA>.
In addition, some minor comments that would be great to improve:

* I can see quite many warning ("discarding unmoored doc comment", "a type
was inferred to be `Any`; this may indicate a programming error", "Adapting
argument list by creating a 4-tuple: this may not be what you want",
etc) during build that would be better to solve.
* More people should add theirs GPG keys to the project file, just in case
anybody else acts as RM in new releases

If you point me how to sort-out the issue with the missing dependency, I'm
more than happy to revise my vote. But, as I pointer in another email,
remember I'd only have 24 hours from now until I'll go on vacations.

Thanks.

Cheers,


On Thu, Sep 1, 2016 at 11:53 AM, DO YUNG YOON <[email protected]> wrote:

> Hi all,
>
> This is a call for a releasing Apache S2Graph 0.1.0-incubating, release
> candidate 2.
> This is the first release of S2Graph.
>
> The source tarball, including signatures, digests, etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.
> 1.0-incubating-RC2/
>
> The tag to be voted upon is v0.1.0-incubating-rc2:
> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.
> git;a=shortlog;h=refs/tags/v0.1.0-incubating-rc2
>
> The release hash is c2f3fc21b40bf21611e242c63146e847de28f5e5:
> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.
> git;a=commit;h=c2f3fc21b40bf21611e242c63146e847de28f5e5
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/dev/incubator/s2graph/KEYS
>
> Once download source, please look into README.md and BUILD.md to build from
> source.
>
> Please refer sub-tasks of S2GRAPH-86(
> https://issues.apache.org/jira/browse/S2GRAPH-86) to check addressed
> issues
> from RC1.
>
> The vote will be open for 72 hours.
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build from source, and test.
> please vote:
>
> [ ] +1 Release this package as 0.1.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because...
>
> Thanks,
> DOYUNG YOON.
>



-- 
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: [email protected]
w: http://redlink.co

Reply via email to