[
https://issues.apache.org/jira/browse/S2GRAPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464108#comment-15464108
]
DOYUNG YOON commented on S2GRAPH-105:
-------------------------------------
[~wikier] Quick Question on merge process of PR from Github.
Following was what I have used to merge PR from Github(Please point out any bad
practice if there is any).
1. create local branch from apache master
{noformat}
git checkout -b <local-branch-for-pr> apache/master`
{noformat}
2. pull PR from remote-branch.
{noformat}
git pull https://github.com/<github-user>/incubator-s2graph.git <remote-branch>
{noformat}
3. run test and validates and add PR into change log(CHANGES).
4. merge into local master.
{noformat}
git checkout master
git merge --squash <local-branch-for-pr>
{noformat}
5. commit with following template.
{noformat}
[S2GRAPH-<ISSUE Number>]: description of issue.
JIRA:
[S2GRAPH-<ISSUE Number>]
https://issues.apache.org/jira/browse/S2GRAPH-<ISSUE Number>
Pull Request:
Closes #<PR Number>
Authors
<github-user>: <email of github user>
{noformat}
I don't understand of the last part exactly, so please elaborate it bit more
for me.
{noformat}
BTW, the merge of a PR should keep the original commits. See how is recommended
to be done in Apache:
{noformat}
Is this mean that we should not squash commits on the original PR?
> Generated tarball contains full path where package was built
> ------------------------------------------------------------
>
> Key: S2GRAPH-105
> URL: https://issues.apache.org/jira/browse/S2GRAPH-105
> Project: S2Graph
> Issue Type: Bug
> Reporter: Sergio Fernández
> Assignee: DOYUNG YOON
> Priority: Trivial
>
> Checking RC2 I've realized that generated tarball contains full path where
> package was built.
> I.e., assuming you have s2graph source code at {{/foo/bar}}, the {{.tar.gz}}
> will inside contain the binary at
> {{/foo/bar/target/apache-s2graph-0.1.0-incubating-bin/...}}, which may not be
> a good idea when later deploying the binary somewhere else.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
