[
https://issues.apache.org/jira/browse/S2GRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534861#comment-15534861
]
ASF GitHub Bot commented on S2GRAPH-116:
----------------------------------------
GitHub user jongwook opened a pull request:
https://github.com/apache/incubator-s2graph/pull/85
[S2GRAPH-116] using ASM and ByteBuddy to add a proxy to Asynchbase's Scanner
This commit adds `object AsynchbasePatcher`, which patches Asynchbase's
`Scanner` class before its loading, to make it a non-final class, and uses
ByteBuddy to dynamically create a subclass of `Scanner` that supports an
RPC-level timeout support, by adding a bean property `int rpcTimeout` and
overriding `getNextRowsRequest()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongwook/incubator-s2graph S2GRAPH-116
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 3644ca3de006c739851e843423f6a36dfb04ce52
Author: Jong Wook Kim <[email protected]>
Date: 2016-09-27T06:28:30Z
[S2GRAPH-116] using ASM and ByteBuddy to add a proxy to Asynchbase's Scanner
----
> Use the official Asynchbase release and stop managing our custom fork
> ---------------------------------------------------------------------
>
> Key: S2GRAPH-116
> URL: https://issues.apache.org/jira/browse/S2GRAPH-116
> Project: S2Graph
> Issue Type: Improvement
> Reporter: Jong Wook Kim
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Currently we are using our custom version of Asynchbase (at
> https://github.com/SteamShon/asynchbase ) for the non-blocking access to
> HBase servers, because of the two minor but essential missing features of the
> upstream Asynchbase:
> 1. to set store_limit and store_offset in GetRequests
> 2. to set the rpc-level timeout values in Scanners
> During the recent discussion in the dev mailing list we've found that the
> former can be replaced with ColumnPaginationFilter, and the latter we can
> workaround using ASM and ByteBuddy.
> This will remove the operational cost of managing a separate fork of
> Asynchbase as well as dealing with the separate release cycle to Maven
> central.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
