Hi folks. After discussion at ApacheCon BigData Europe(sevile), I was wondering if it is possible to change S2Graph's core library to implement tp3's interface directly rather than providing layer atop of existing codebase.
I have updated corresponding issue <https://issues.apache.org/jira/browse/S2GRAPH-72> and create 2 sub tasks( S2GRAPH-129 <https://issues.apache.org/jira/browse/S2GRAPH-129> , S2GRAPH-130 <https://issues.apache.org/jira/browse/S2GRAPH-130> ) to try out this idea. @committers, Please review PR99 <https://github.com/apache/incubator-s2graph/pull/99>, PR100 <https://github.com/apache/incubator-s2graph/pull/100> so we can proceed to implement all interfaces of tp3 actually. I intentionally left actual implementation omitted because it can be changed after this discussion. Apart from that, Here are few things I want to discuss regarding support Apache TinkerPop and Gremlin. 1. Data type of property value. Currently S2Graph only support types available on JSON. is this ok? are we going to support any other type? If then, What need to be done to support other data type on property's value. 2. No notion of VertexProperty. Property is same on Vertex and Edge in S2Graph so we have to decide what's our S2VertexProperty would be. Are we going to support this or just say we can't provide it(for now or what). 3. Vertex Id: S2Graph use ServiceColumn + UserProvidedId as internal vertex Id. We need to decide how we are going to map ServiceColumn into tp3's Verte. Are we going to serialize/deserialize ServiceColumn into tp3's Vertex label or not? Not just about ServiceColumn but want to discuss further about what S2Graph are going to provide through tp3's interface and how. Please feel free to comment on not only above but also anything regarding to tp3 support in general. Thanks.
