[
https://issues.apache.org/jira/browse/S2GRAPH-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715496#comment-15715496
]
ASF GitHub Bot commented on S2GRAPH-132:
----------------------------------------
GitHub user daewon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/105
[S2GRAPH-132] Added the ability to buffer write rpc for increment requests.
This feature will reduce the number of RPCs delivered to each region and
will therefore improve increment performance.
I've discovered a few issues while adding this feature.
The data on the Edge has changed where i did not expected it.
It appears that the Edge class has been changed to a mutable.
To solve this problem, I used a deepCopied of the Edge where i created the
RPC
I would like to discuss this in another thread to find a more fundamental
cause.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-132
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 20bdf9291acfbb830db441490e1d5351fa8a0ca3
Author: daewon <[email protected]>
Date: 2016-12-01T15:11:04Z
[S2GRAPH-135] Change the way LabelIndexOption is implemented and improve it
commit 478db844a0c7322f51c2e75f2fbee1bf4c492902
Author: daewon <[email protected]>
Date: 2016-12-02T14:52:26Z
[S2GRAPH-132] add functionality for buffering increment
----
> Support buffering for 'Increment RPC'
> -------------------------------------
>
> Key: S2GRAPH-132
> URL: https://issues.apache.org/jira/browse/S2GRAPH-132
> Project: S2Graph
> Issue Type: Improvement
> Reporter: Daewon Jeong
> Assignee: Daewon Jeong
> Priority: Minor
>
> Since Issue {{S2GRAPH-123}} has been applied, it is now possible to save
> degree information only for a specific direction(in, or out).
> The reason for dropping the 'in direction edge' is to prevent the super node
> where the key is driven by one region.
> In this case, buffering RPC for store degree can reduce the burden on the
> region.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
