[
https://issues.apache.org/jira/browse/S2GRAPH-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731362#comment-15731362
]
ASF GitHub Bot commented on S2GRAPH-107:
----------------------------------------
Github user ijsong commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/109#discussion_r91455719
--- Diff:
loader/src/main/scala/org/apache/s2graph/loader/subscriber/GraphSubscriber.scala
---
@@ -19,45 +19,61 @@
package org.apache.s2graph.loader.subscriber
+import scala.collection.JavaConversions._
+import scala.collection.mutable.HashMap
+import scala.concurrent.ExecutionContext
+
import com.typesafe.config.{Config, ConfigFactory}
import kafka.javaapi.producer.Producer
import kafka.producer.KeyedMessage
import org.apache.hadoop.hbase.HBaseConfiguration
import org.apache.hadoop.hbase.client._
+import org.apache.spark.Accumulable
+
import org.apache.s2graph.core._
import org.apache.s2graph.spark.spark.WithKafka
-import org.apache.spark.{Accumulable, SparkContext}
-import scala.collection.JavaConversions._
-import scala.collection.mutable.HashMap
-import scala.concurrent.ExecutionContext
object GraphConfig {
var database = ""
var zkQuorum = ""
var kafkaBrokers = ""
var cacheTTL = s"${60 * 60 * 1}"
- def apply(phase: String, dbUrl: Option[String], zkAddr: Option[String],
kafkaBrokerList: Option[String]): Config = {
+
+ def apply(phase: String,
+ dbUrl: Option[String],
+ zkAddr: Option[String],
+ kafkaBrokerList: Option[String]): Config = {
database = dbUrl.getOrElse("jdbc:mysql://localhost:3306/graph_dev")
zkQuorum = zkAddr.getOrElse("localhost")
-// val newConf = new util.HashMap[String, Object]()
-// newConf.put("hbase.zookeeper.quorum", zkQuorum)
-// newConf.put("db.default.url", database)
-// newConf.put("kafka.metadata.broker.list", kafkaBrokers)
+ // val newConf = new util.HashMap[String, Object]()
+ // newConf.put("hbase.zookeeper.quorum", zkQuorum)
+ // newConf.put("db.default.url", database)
+ // newConf.put("kafka.metadata.broker.list", kafkaBrokers)
--- End diff --
@HyunsungJo Yes, we can remove comments which have no useful information.
> Improve code readability by using code formatter and code style inspector
> like Scalafmt and Scalastyle
> ------------------------------------------------------------------------------------------------------
>
> Key: S2GRAPH-107
> URL: https://issues.apache.org/jira/browse/S2GRAPH-107
> Project: S2Graph
> Issue Type: Wish
> Reporter: Injun Song
> Priority: Minor
>
> Readability of S2Graph can be improved by using code formatter.
> There are known code formatters for Scala.
> - https://olafurpg.github.io/scalafmt
> - https://github.com/scala-ide/scalariform
> Moreover, to improve readability and code styles, we can modify several
> settings in Scalastyle.
> Code formatter and Scalastyle can be used together.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
