[ 
https://issues.apache.org/jira/browse/S2GRAPH-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

DOYUNG YOON updated S2GRAPH-146:
--------------------------------
    Description: 
Currently we have two IndexEdgeDeserializable class both for tall/wide schema.

I suggest to refactor these so we can just call one single 
IndexEdgeDeserializable without knowing which label we are traversing on. 

Currently, caller should pass QueryParam which specify {{Label}} we are 
searching for, but to deal with *search for all available {{Label}}* get 
complicated with this restriction. If user want to fetch all edges stored, then 
things get complicated.

It would be better for {{Deserializable}} to know which {{Label}} we are 
deserializing while deserialize {{KeyValue}} from storage rather than depending 
on parameter passed from caller. 

  was:
Currently we have two IndexEdgeDeserializable class both for tall/wide schema.

I suggest to refactor these so we can just call one single 
IndexEdgeDeserializable without knowing which label we are traversing on. 

Currently, caller should pass QueryParam which specify {{Label}} we are 
searching for, but to deal with `search for all available {{Label}}` get 
complicated with this restriction. If user want to fetch all edges stored, then 
things get complicated.

It would be better for {{Deserializable}} to know which {{Label}} we are 
deserializing while deserialize {{KeyValue}} from storage rather than depending 
on parameter passed from caller. 


> Merge two IndexEdgeDeserializable under tall, wide package into one.
> --------------------------------------------------------------------
>
>                 Key: S2GRAPH-146
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-146
>             Project: S2Graph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently we have two IndexEdgeDeserializable class both for tall/wide schema.
> I suggest to refactor these so we can just call one single 
> IndexEdgeDeserializable without knowing which label we are traversing on. 
> Currently, caller should pass QueryParam which specify {{Label}} we are 
> searching for, but to deal with *search for all available {{Label}}* get 
> complicated with this restriction. If user want to fetch all edges stored, 
> then things get complicated.
> It would be better for {{Deserializable}} to know which {{Label}} we are 
> deserializing while deserialize {{KeyValue}} from storage rather than 
> depending on parameter passed from caller. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to