-1 (non-binding)

I tried RC1(
https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.2.0-incubating-RC1/)
on ubuntu 16.04, SBT 0.13.9, SCALA 2.11.7, OpenJDK 1.8.0_91.

Checked followings.

1. Checksums and PGP signatures are valid
2. Release consists of source code only, no binaries
3. DISCLAIMER is correct, filenames include "incubating", top level NOTICE
and LICENSE files.
4. Check license header on files by following DEVELOPMENT.md.
5. Test if I can run `bin/example.sh` after build.
6. `sbt compile`, `sbt test:compile` to see any compile errors.
7. `sbt "project loader" assembly`, `sbt "project s2counter_loader"`
assembly to see executable jar successfully built from source.
8. `sbt test` to see if all test cases passed.


I found error on 8, more specifically InnerValTest failed on "korean".

I am going to create issue for fixing this and re-open vote thread with RC2
once this bug fixed.



On Mon, Aug 7, 2017 at 2:30 PM DO YUNG YOON <sho...@gmail.com> wrote:

> Hi all
>
> This is a call for a releasing Apache S2Graph 0.2.0-incubating, release
> candidate 1.
>
> The source tarball, including signatures, digests, etc. can be found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.2.0-incubating-RC1
>
> The tag to be voted upon is v0.2.0-incubating-rc1:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.git;a=shortlog;h=refs/tags/v0.2.0-incubating-rc1
>
> The release hash is cddbaa48290b2d38b1d0f8c6401b0535689f6a49:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.git;a=commit;h=cddbaa48290b2d38b1d0f8c6401b0535689f6a49
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/dev/incubator/s2graph/KEYS
>
> Once download source, please look into README.md to build from source.
>
> Notable changes from 0.1.0 is providing tinkerpop3 integration(S2GRAPH-72,
> S2GRAPH-151).
>
> The vote will be open for at least 72 hours. Unless objection I will try
> to close it Wednesday August 9 if we have sufficient votes.
>
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build from source, and test.
> please vote:
>
> [ ] +1 Release this package as 0.2.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because...
>
> Thanks,
> DOYUNG YOON.
>

Reply via email to