ASF GitHub Bot commented on S2GRAPH-158:

GitHub user SteamShon opened a pull request:


    [S2GRAPH-158]: Bug fix on org.apache.s2graph.core.types.v2.InnerVal

    - add charsetName as `UTF-8` on String.getBytes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-158

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
commit a19437fe79fc9c129fcca410c31efc51c54d6cca
Author: DO YUNG YOON <steams...@apache.org>
Date:   2017-08-07T07:21:46Z

    add "UTF-8" encoding on String.getBytes method.


> Bug fix on org.apache.s2graph.core.types.v2.InnerVal
> ----------------------------------------------------
>                 Key: S2GRAPH-158
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-158
>             Project: S2Graph
>          Issue Type: Sub-task
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Blocker
>              Labels: bug
>             Fix For: 0.2.0
>   Original Estimate: 72h
>  Remaining Estimate: 72h
> Current master's test failed on following environment and I think it is 
> because of usage of getBytes without specifying encoding on InnerVal class.
> More specifically, I think String's getBytes without encoding cause different 
> result.
> {noformat}
>  case s: String =>
>         val pbr = new SimplePositionedMutableByteRange(s.getBytes.length + 3)
>         val len = OrderedBytes.encodeString(pbr, s, order)
>         pbr.getBytes().take(len)
> {noformat}
> I am suggesting change String type InnerVal's serialize/deserialize to use 
> UTF-8 encoding so running environment do not break test cases.

This message was sent by Atlassian JIRA

Reply via email to