[
https://issues.apache.org/jira/browse/S2GRAPH-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116196#comment-16116196
]
ASF GitHub Bot commented on S2GRAPH-158:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-s2graph/pull/117
> Bug fix on String type InnerVal encoding to use UTF-8 charsetName.
> ------------------------------------------------------------------
>
> Key: S2GRAPH-158
> URL: https://issues.apache.org/jira/browse/S2GRAPH-158
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Blocker
> Labels: bug
> Fix For: 0.2.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Current master's test failed on following environment and I think it is
> because of usage of getBytes without specifying encoding on InnerVal class.
> More specifically, I think String's getBytes without encoding cause different
> result.
> {noformat}
> case s: String =>
> val pbr = new SimplePositionedMutableByteRange(s.getBytes.length + 3)
> val len = OrderedBytes.encodeString(pbr, s, order)
> pbr.getBytes().take(len)
> {noformat}
> I am suggesting change String type InnerVal's serialize/deserialize to use
> UTF-8 encoding so running environment do not break test cases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
