[ 
https://issues.apache.org/jira/browse/S2GRAPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123376#comment-16123376
 ] 

DOYUNG YOON commented on S2GRAPH-160:
-------------------------------------

I removed few warnings which can be fixed easily.

Followings are warnings which are left over, and it is quite hard to remove 
them 

1. library dependencies: We need to take time to investigate clean up which 
library cause following incompatibilities.

{noformat}
[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * io.netty:netty:3.6.2.Final -> 3.9.4.Final
[warn]  * com.google.guava:guava:(18.0, 11.0.2) -> 12.0.1
[warn] Run 'evicted' to see detailed eviction warnings

[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * io.netty:netty-all:4.0.23.Final -> 4.0.33.Final
[warn]  * com.google.guava:guava:(18.0, 11.0.2) -> 12.0.1
[warn] Run 'evicted' to see detailed eviction warnings

[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * com.google.guava:guava:(11.0.2, 18.0) -> 12.0.1
[warn] Run 'evicted' to see detailed eviction warnings
[info] Resolving org.slf4j#slf4j-api;[1.6.0,) ...
[warn] one warning found

[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * com.google.guava:guava:(19.0, 16.0.1, 18.0, 11.0.2) -> 12.0.1
[warn] Run 'evicted' to see detailed eviction warnings

[warn] Multiple dependencies with the same organization/name but different 
versions. To avoid conflict, pick one version:
[warn]  * com.google.guava:guava:(12.0.1, 16.0.1)
[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * io.netty:netty-all:4.0.23.Final -> 4.0.40.Final
[warn]  * com.google.guava:guava:(16.0.1, 19.0, 18.0, 11.0.2) -> 12.0.1
[warn] Run 'evicted' to see detailed eviction warnings

[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn]  * com.google.guava:guava:(11.0.2, 19.0, 16.0.1, 18.0) -> 12.0.1
[warn] Run 'evicted' to see detailed eviction warnings

{noformat}


2. Depereated methods on Tinkerpop3: Need to figure out how to pass java 
Consumer from scala.

{noformat}
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2core/src/main/scala/org/apache/s2graph/core/S2Graph.scala:1940:
 method registry in trait Builder is deprecated: see corresponding Javadoc for 
more information.
[warn]     
builder.graph(this).registry(S2GraphIoRegistry.instance).create().asInstanceOf[I]
[warn]
{noformat}

3. Deprecated methods from Play framework: There are some changes from play 
2.3.x to 2.5.x, so I think it is better to take time to upgrade this on 
separate issue.

{noformat}
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/Bootstrap.scala:38:
 class WithFilters in package mvc is deprecated: Use dependency injection
[warn] object Global extends WithFilters(new GzipFilter()) {
[warn]                       ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/actors/QueueActor.scala:50:
 method system in object Akka is deprecated: Please use a dependency injected 
ActorSystem
[warn]     router = Akka.system.actorOf(props(s2, walLogHandler))
[warn]                   ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/actors/QueueActor.scala:55:
 method shutdown in class ActorSystem is deprecated: Use the terminate() method 
instead
[warn]     Akka.system.shutdown()
[warn]                 ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/actors/QueueActor.scala:55:
 method system in object Akka is deprecated: Please use a dependency injected 
ActorSystem
[warn]     Akka.system.shutdown()
[warn]          ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/config/Config.scala:36:
 method current in object Play is deprecated: This is a static reference to 
application, use DI instead
[warn]   lazy val conf = Play.current.configuration
[warn]                        ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/controllers/CounterController.scala:47:
 method current in object Play is deprecated: This is a static reference to 
application, use DI instead
[warn]   val config = Play.current.configuration.underlying
[warn]                     ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/controllers/JsonBodyParser.scala:106:
 method maybeApplication in object Play is deprecated: This is a static 
reference to application, use DI instead
[warn]     Play.maybeApplication.map(_.global.onBadRequest(request, msg))
[warn]          ^
[warn] 
/Users/shon/Workspace/incubator-s2graph/s2rest_play/app/org/apache/s2graph/rest/play/controllers/JsonBodyParser.scala:106:
 method global in trait Application is deprecated: Use dependency injection
[warn]     Play.maybeApplication.map(_.global.onBadRequest(request, msg))
[warn]
{noformat}

In summary, It would be best if we can resolve above to remove all warnings, 
but I think it will take some time.

I am suggesting to close this issue for 0.2.0-release, then create separate 
issues and resolve them on upcoming release.

Any thought?

> Remove warning while package
> ----------------------------
>
>                 Key: S2GRAPH-160
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-160
>             Project: S2Graph
>          Issue Type: Sub-task
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>             Fix For: 0.2.0
>
>
> There are some warnings on the build. It would be better to clean up warnings.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to