[ 
https://issues.apache.org/jira/browse/S2GRAPH-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361894#comment-16361894
 ] 

DOYUNG YOON commented on S2GRAPH-172:
-------------------------------------

[~daewon]

I think we need to add apache license header to every file including 
configuration files. Usually, this is done by running `dev/run-rat.sh 
path/to/apache-rat-jar` and check `rat.out` file. 

One thing I am worried about is the license of 
`s2graphql/src/main/resources/graphiql.html` file. It seems it contains 
facebook license header, and I think it is not compatible with Apache v2 
license.  

Is it necessary to include `graphiql.html` file for this issue? 

> Suggest to implement GraphQL as standard web interface for S2Graph.
> -------------------------------------------------------------------
>
>                 Key: S2GRAPH-172
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-172
>             Project: S2Graph
>          Issue Type: New Feature
>            Reporter: Daewon Jeong
>            Priority: Minor
>              Labels: features
>
> GraphQL Support
> Suggest to implement GraphQL as standard web interface for S2Graph.
> S2Graph's query is implemented in its own way, it provides many features, but 
> it is not easy to learn this query from the user.
> I would like to hear how you can provide the GraphQL function for convenient 
> use of S2Graph.
> p.s: Graph QL has nothing to do with Graph DataBase, and Graph search is not 
> the purpose of GraphQL.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to