[ https://issues.apache.org/jira/browse/S2GRAPH-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420189#comment-16420189 ]
ASF GitHub Bot commented on S2GRAPH-190: ---------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-s2graph/pull/147 > Remove unnecessary TC JsonBenchmarkSpec > --------------------------------------- > > Key: S2GRAPH-190 > URL: https://issues.apache.org/jira/browse/S2GRAPH-190 > Project: S2Graph > Issue Type: Task > Reporter: Daewon Jeong > Assignee: Daewon Jeong > Priority: Trivial > > There is a test case that has been created to measure the speed required for > the Json build, which unnecessarily increases the test time. > I think it's better to erase the measured test. > The link below shows how much time JsonSpec consumes unnecessarily. > https://travis-ci.org/apache/incubator-s2graph/builds/359216779?utm_source=github_status&utm_medium=notification > {noformat} > ================================================== > map to json: took 776 ms > ================================================== > ================================================== > direct: took 38599 ms > ================================================== > ================================================== > Append by JsObj ++ JsObj : took 79299 ms > ================================================== > ================================================== > Append by Json.obj(newJson -> JsObj): took 107 ms > ================================================== > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)