[ 
https://issues.apache.org/jira/browse/S2GRAPH-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518974#comment-16518974
 ] 

ASF GitHub Bot commented on S2GRAPH-228:
----------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/176

    [S2GRAPH-228]: GraphQL empty variable fields on post request cause 
spray.json.DeserializationException.

    - filterNot JsNull instead of null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-228

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit 9435aa540cb15bfc6a94a452a4a6b24854b8d166
Author: DO YUNG YOON <steamshon@...>
Date:   2018-06-21T06:22:43Z

    filterNot JsNull instead of null.

----


> GraphQL empty variable fields on post request cause 
> spray.json.DeserializationException.
> ----------------------------------------------------------------------------------------
>
>                 Key: S2GRAPH-228
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-228
>             Project: S2Graph
>          Issue Type: Bug
>          Components: s2graphql
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Trivial
>
> When send post request with empty variable on GraphiQL cause following erros.
> {noformat}
> s2graphql spray.json.DeserializationException: JSON object expected
> s2graphql     at spray.json.package$.deserializationError(package.scala:23)
> s2graphql     at spray.json.JsValue.asJsObject(JsValue.scala:36)
> s2graphql     at spray.json.JsValue.asJsObject(JsValue.scala:41)
> s2graphql     at 
> org.apache.s2graph.graphql.Server$$anonfun$4$$anonfun$apply$4$$anonfun$apply$9$$anonfun$apply$12.apply(HttpServer.scala:92)
> s2graphql     at 
> org.apache.s2graph.graphql.Server$$anonfun$4$$anonfun$apply$4$$anonfun$apply$9$$anonfun$apply$12.apply(HttpServer.scala:92)
> s2graphql     at 
> akka.http.scaladsl.server.directives.RouteDirectives$$anonfun$complete$1.apply(RouteDirectives.scala:47)
> s2graphql     at 
> akka.http.scaladsl.server.directives.RouteDirectives$$anonfun$complete$1.apply(RouteDirectives.scala:47)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to