ASF GitHub Bot commented on S2GRAPH-231:

GitHub user daewon opened a pull request:


    [S2GRAPH-231] Change the GraphQL type name to a valid string.

    I added the `toValidaName` function to create a valid string in GraphQL and 
applied it to `ObjectName`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-231

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
commit 8ff8c233e8a4f1194702c649bff3f5a99cb8273d
Author: daewon <daewon@...>
Date:   2018-07-10T05:20:37Z

    add toValidName


> Change the GraphQL type name to a valid string.
> -----------------------------------------------
>                 Key: S2GRAPH-231
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-231
>             Project: S2Graph
>          Issue Type: Improvement
>          Components: s2graphql
>            Reporter: Daewon Jeong
>            Priority: Minor
> Below is a regular expression for valid strings in GraphQL.
> {code:scala}
> val validateRegEx = "/^[_a-zA-Z][_a-zA-Z0-9]*$/.".r
> {code}
> ex) invalid type name
>   1. '-label' : hyphen
>   2. '100k' : starts with numeric
>   3. 'one-more' : hyphen
> Label, service, serviceColumn, etc. created before S2Graph supports GraphQL 
> do not follow the regular expression rule.
> Provides the ability to convert an invalid name to a valid name for backwards 
> compatibility.

This message was sent by Atlassian JIRA

Reply via email to