ASF GitHub Bot commented on S2GRAPH-245:

GitHub user SteamShon opened a pull request:


    [S2GRAPH-245]: Remove install hbase step on travis CI.

    - remove install hbase on travis CI.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-245

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
commit 22c64965b94e9bd707ed99b6e770ebd006400369
Author: DO YUNG YOON <steamshon@...>
Date:   2018-11-02T02:06:06Z

    remove install hbase on travis CI.


> Remove install hbase step on travis CI.
> ---------------------------------------
>                 Key: S2GRAPH-245
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-245
>             Project: S2Graph
>          Issue Type: Task
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Minor
>   Original Estimate: 48h
>  Remaining Estimate: 48h
> Currently, we download hbase binary using following script to setup travis CI.
> {noformat}
> wget -q -O - 
> http://mirror.apache-kr.org/hbase/$HBASE_VERSION/hbase-$HBASE_VERSION-bin.tar.gz
> {noformat}
> apache dist only keep few versions, so whenever hbase release new version, we 
> keep having to change the environment variable HBASE_VERSION to point out the 
> new stable version.
> then start hbase before test begin
> {noformat}
> before_install:
>   - .travis/install-hbase.sh
> before_script:
>   - $HOME/hbase-$HBASE_VERSION/bin/start-hbase.sh
> {noformat}
> I was wondering if there any particular reason to explicitly download the 
> specific version of HBase and run as a separate process on the test.
> I have checked if our test runs without any remote HBase process running, and 
> it has passed, so I do not think we actually need to setup HBase at all.
> I suggest removing setup hbase step on .travis.yml if there is no reason.

This message was sent by Atlassian JIRA

Reply via email to