[ 
https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702614#comment-16702614
 ] 

DOYUNG YOON edited comment on S2GRAPH-248 at 11/29/18 1:56 AM:
---------------------------------------------------------------

[~daewon] Hi daewon. 

I copied missing APIs from s2rest_play to s2http based on your branch(remote: 
daewon, branch: S2GRAPH0248). 

I am not very familiar with akka http yet, so please review the 
PR(https://github.com/daewon/incubator-s2graph/pull/3) and let me know if there 
are the better way to implement these.




was (Author: steamshon):
[~daewon] Hi daewon. 

I copied missing APIs from s2rest_play to s2http based on your branch(remote: 
daewon, branch: S2GRAPH0248). 

I am not very familiar with akka http yet, so please review the 
PR(https://github.com/daewon/incubator-s2graph/pull/3) and let me know if there 
are better way to implement these.



> HTTP interface integration.
> ---------------------------
>
>                 Key: S2GRAPH-248
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-248
>             Project: S2Graph
>          Issue Type: Task
>          Components: s2core, s2rest_netty, s2rest_play
>            Reporter: Daewon Jeong
>            Priority: Minor
>
> The current HTTP interface in S2Graph has the following problems.
>  known issues:
>    1. The `s2rest_netty` project is experimental and supports only `graph 
> traverse` API.
>    2. `s2rest_play` based on Play! Framework. 
>       - Play! Framework is full stack framework, so it has a lot of 
> dependencies that s2graph does not need. 
>       - There is also a conflict with byte buddy for patching asynchbase.
>    3. `GraphQL` is still in the experimental phase and does not yet provide 
> all the functionality.
> The discussion below is written on the link below.
> discussions: 
> [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E]
>  
> Based on this issue, the following work should be done.
>  * Create an HTTP interface project(without play!)
>  * Remove s2rest_netty
>  * API documentation (GraphQL, Rest)
>  * GraphQL and Rest HTTP interface integration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to