DOYUNG YOON commented on S2GRAPH-248:

[~daewon] Thanks for reviewing and mering it!

I think we moved most of APIS on 
Here is the list I think we need to do for this issue.

1. add routes for s2graphql.
I think it would be good for s2graphql project to hold graphql specific code, 
not http parts, then let s2http depends on s2graphql and add `Route` for 
graphql support on the s2http.

2. documentation
since few APIs has been changed, I think it would be good to update document on 
our new documtation directory `doc`. Let's discuss how we document routes so 
users can try s2http more easily.

3. test cases
I am not sure if we need full test cases on every routes in s2http, since all 
it does is pretty much unmarshall http request and call S2Graph's internal 
method. Since we have basic test cases covered on s2core, I think we can skip 
this and separate adding test cases as separate task.

4. startup script
Change scripts to support s2http, and make sure it works.

5. deprecate s2rest_play, s2rest_netty
Announce the deprecation of s2rest_netty, s2rest_play on our mailing.

Please feel free to comments.

> HTTP interface integration.
> ---------------------------
>                 Key: S2GRAPH-248
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-248
>             Project: S2Graph
>          Issue Type: Task
>          Components: s2core, s2rest_netty, s2rest_play
>            Reporter: Daewon Jeong
>            Priority: Minor
> The current HTTP interface in S2Graph has the following problems.
>  known issues:
>    1. The `s2rest_netty` project is experimental and supports only `graph 
> traverse` API.
>    2. `s2rest_play` based on Play! Framework. 
>       - Play! Framework is full stack framework, so it has a lot of 
> dependencies that s2graph does not need. 
>       - There is also a conflict with byte buddy for patching asynchbase.
>    3. `GraphQL` is still in the experimental phase and does not yet provide 
> all the functionality.
> The discussion below is written on the link below.
> discussions: 
> [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E]
> Based on this issue, the following work should be done.
>  * Create an HTTP interface project(without play!)
>  * Remove s2rest_netty
>  * API documentation (GraphQL, Rest)
>  * GraphQL and Rest HTTP interface integration

This message was sent by Atlassian JIRA

Reply via email to