Github user gdfm commented on a diff in the pull request:
https://github.com/apache/incubator-samoa/pull/32#discussion_r35090534
--- Diff: samoa-api/pom.xml ---
@@ -101,6 +101,16 @@
<version>${hadoop.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
+ <version>0.8.2.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka_2.10</artifactId>
+ <version>0.8.1</version>
--- End diff --
Why two separate versions for Kafka and Kafka-clients?
Also, is Kafka really needed?
And if so, should it be declared as provided?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
