[
https://issues.apache.org/jira/browse/SAMOA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661544#comment-14661544
]
ASF GitHub Bot commented on SAMOA-29:
-------------------------------------
Github user jayadeepj commented on the pull request:
https://github.com/apache/incubator-samoa/pull/34#issuecomment-128649878
Hi @gdfm, Thanks for the review.
I am under the impression this fix is for Storm's Local mode and not the
'Local Test Mode' of SAMOA itself. The fix is made in LocalStormDoTask of
samoa-storm (and not the LocalDoTask of samoa-local). I guess you have invoked
it bin/samoa local target/SAMOA-Local-0.4.0-incubating-SNAPSHOT.jar ....
I have tested it with bin/samoa storm
target/SAMOA-Storm-0.4.0-incubating-SNAPSHOT.jar "PrequentialEvaluation -l
classifiers.ensemble.Bagging -s (ArffFileStream -f covtypeNorm.arff) -f 100000".
Though I will run it again & check it to confirm. Please correct if my
understanding is wrong.
> Remove hardcoded value for the duration of Storm local topology execution
> -------------------------------------------------------------------------
>
> Key: SAMOA-29
> URL: https://issues.apache.org/jira/browse/SAMOA-29
> Project: SAMOA
> Issue Type: Bug
> Components: SAMOA-Storm
> Reporter: Gianmarco De Francisci Morales
>
> From GitHub:
> In Storm local mode, the topology always executes for at most 10 minutes.
> Refer to com.yahoo.labs.samoa.LocalStormDoTask line 72.
> Possible solutions:
> 1) Add a new option to determine local topology execution duration in
> bin\samoa-storm.properties, use bin\samoa to parse the new option and pass to
> LocalStormDoTask as program argument.
> 2) Add the same new option as solution 1, use commons-configuration package
> to parse bin\samoa-storm.properties.
> For the second solution, we modify LocalStormDoTask to read the
> samoa-storm.properties using PropertiesConfiguration class of Apache
> commons-configuration. It will eliminate bash-code parsing in bin/samoa for
> all options except for $MODE_ARG.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
