Github user jayadeepj commented on the pull request:
https://github.com/apache/incubator-samoa/pull/34#issuecomment-128720359
Hi @gdfm, yes you are right. I had made a compile time addition of the
property file to the jar in pom.xml. I did that to avoid a code like this
_config = new
PropertiesConfiguration(/some/hardcoded/path/to/bin/samoa-storm.properties)_
Also We may not be able to simply omit samoa-storm.properties from the jar,
as the samoa-storm.properties need to be in classpath for the
PropertiesConfiguration to pick it up. The second alternative that is to
update the bin/samoa script to add 'bin' directory to the CLASSPATH something
like
_CLASSPATH="$CLASSPATH:$STORM_HOME/lib/*:$BASE_DIR/:$DEPLOYABLE"
java -cp $CLASSPATH org.apache.samoa.LocalStormDoTask $COMPLETE_ARG
$NUM_WORKER_
In this second alternative, we may need to update pom.xml to include a
testResources as well for the storm junits. Let me know your thoughts. Will be
happy to implement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
