Github user edi-bice commented on a diff in the pull request:
https://github.com/apache/incubator-samoa/pull/48#discussion_r56018727
--- Diff:
samoa-instances/src/main/java/org/apache/samoa/instances/AvroLoader.java ---
@@ -254,12 +257,30 @@ protected InstanceInformation getHeader() {
List<String> attributeLabels = attributeSchema.getEnumSymbols();
attributes.add(new Attribute(field.name(), attributeLabels));
}
- else
+ else if (isNumeric(field))
--- End diff --
You are correct and hopefully agree that it is an improvement as it is now
accepting of more data sets (including mine with has way too many string
attributes - could add a pre-processing step/job before Samoa but thought this
nice to have regardless).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
