[ 
https://issues.apache.org/jira/browse/SAMOA-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059472#comment-16059472
 ] 

ASF GitHub Bot commented on SAMOA-68:
-------------------------------------

Github user gdfm commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/61#discussion_r123518192
  
    --- Diff: 
samoa-api/src/main/java/org/apache/samoa/evaluation/BasicRegressionPerformanceEvaluator.java
 ---
    @@ -92,6 +106,22 @@ public void addResult(Instance inst, double[] 
prediction) {
         };
       }
     
    +  /**
    +   * This method is used to retrieve predictions
    +   * 
    +   * @return String This returns an array of predictions and votes objects.
    +   */
    +  @Override
    +  public Vote[] getPredictionVotes() {
    +    double trueValue = this.lastSeenInstance.classValue();
    +    return new Vote[] {
    +        new Vote("instance number",
    +            this.instanceIdentifier),
    +        new Vote("true value", trueValue, 10),
    --- End diff --
    
    Can you define a constant with an understandable name for the value 10?


> Saving true and predicted labels to file
> ----------------------------------------
>
>                 Key: SAMOA-68
>                 URL: https://issues.apache.org/jira/browse/SAMOA-68
>             Project: SAMOA
>          Issue Type: New Feature
>          Components: SAMOA-API
>            Reporter: Maciej Grzenda
>              Labels: features
>
> Currently PrequentialEvaluation task supports dumpFile option.  With this 
> option model performance can be saved to a file. However, in some cases it 
> would be good to save also individual predictions made by a model.  This is 
> useful for model debugging and method development.
> This could be also used to visualize model output, calculate custom 
> performance indicators (e.g. model accuracy for instances of a certain class 
> or sharing the same feature value).  Such saving of model output (if done) 
> should be made for every instance. Hence, a new option making it possible to 
> dump predictions to a separate file seems justified.  For classification, it 
> should include votes made for individual classes, if available.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to