-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22215/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-123
    https://issues.apache.org/jira/browse/SAMZA-123


Repository: samza


Description
-------

Move topic partition grouping to the AM and generalize


Diffs
-----

  build.gradle 1a1db16 
  check PRE-CREATION 
  samza-api/src/main/java/org/apache/samza/checkpoint/Checkpoint.java dcf81bf 
  samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java 
34f50fd 
  samza-api/src/main/java/org/apache/samza/container/SSPGrouper.java 
PRE-CREATION 
  samza-api/src/main/java/org/apache/samza/container/SSPGrouperFactory.java 
PRE-CREATION 
  samza-api/src/main/java/org/apache/samza/container/SamzaContainerContext.java 
5aa7a8f 
  samza-api/src/main/java/org/apache/samza/job/CommandBuilder.java 5ec6433 
  samza-api/src/main/java/org/apache/samza/task/TaskContext.java 611507e 
  samza-api/src/test/java/org/apache/samza/container/SSPGrouperTestBase.java 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 
5735a39 
  samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 
9487b58 
  
samza-core/src/main/scala/org/apache/samza/checkpoint/file/FileSystemCheckpointManager.scala
 364e489 
  samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala fcafe83 
  samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala 
4c2d365 
  samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 4ca340c 
  samza-core/src/main/scala/org/apache/samza/container/SSPTaskNameGrouper.scala 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
7ca8af6 
  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 
99a9841 
  
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 
7502124 
  samza-core/src/main/scala/org/apache/samza/container/TaskNameToSSPs.scala 
PRE-CREATION 
  
samza-core/src/main/scala/org/apache/samza/container/ssp/groupers/GroupByPartition.scala
 PRE-CREATION 
  
samza-core/src/main/scala/org/apache/samza/container/ssp/groupers/GroupBySSP.scala
 PRE-CREATION 
  
samza-core/src/main/scala/org/apache/samza/container/ssp/groupers/GroupInNSets.scala
 PRE-CREATION 
  
samza-core/src/main/scala/org/apache/samza/container/ssp/taskname/groupers/SimpleSSPTaskNameGrouper.scala
 PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/job/ShellCommandBuilder.scala 
f8865b1 
  samza-core/src/main/scala/org/apache/samza/job/local/LocalJobFactory.scala 
e20e7c1 
  samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala 
2ed8d7d 
  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 
7214151 
  samza-core/src/main/scala/org/apache/samza/task/ReadableCoordinator.scala 
4ccd604 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd 
  
samza-core/src/test/scala/org/apache/samza/checkpoint/TestCheckpointTool.scala 
bc54f9e 
  samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala 
552f8c2 
  
samza-core/src/test/scala/org/apache/samza/checkpoint/file/TestFileSystemCheckpointManager.scala
 50d9a05 
  samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 
fa10231 
  samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 
190bdfe 
  samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 
1f5e3bb 
  
samza-core/src/test/scala/org/apache/samza/container/ssp/groupers/TestGroupByPartition.scala
 PRE-CREATION 
  
samza-core/src/test/scala/org/apache/samza/container/ssp/groupers/TestGroupBySSP.scala
 PRE-CREATION 
  
samza-core/src/test/scala/org/apache/samza/container/ssp/groupers/TestGroupInNSets.scala
 PRE-CREATION 
  samza-core/src/test/scala/org/apache/samza/job/TestJobRunner.scala 21d8a78 
  
samza-core/src/test/scala/org/apache/samza/serializers/TestCheckpointSerde.scala
 70d8c80 
  samza-core/src/test/scala/org/apache/samza/task/TestReadableCoordinator.scala 
12f1e03 
  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala b8c369b 
  
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala
 62c91e8 
  
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
 cb6dbdf 
  
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
 92ac61e 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala 
dae3c2c 
  samza-test/src/main/java/org/apache/samza/test/integration/join/Emitter.java 
222c130 
  
samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala
 5b9b926 
  
samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala
 10502a9 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 
c28c9a6 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala 
01a2683 
  
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala
 eb1ff54 
  
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala
 17a96f0 
  
samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
 0442580 

Diff: https://reviews.apache.org/r/22215/diff/


Testing
-------

Existing and new unit.  Now moving on to function.


Thanks,

Jakob Homan

Reply via email to