Hey Ruslan, Thanks for taking this on.
> Unfortunately I couldn't submit review request - probably due to git corruption. Tracked here: https://issues.apache.org/jira/browse/INFRA-9105 > Can it be replaced by RocksDB or scaladoc has to be re-written? Just replace with RocksDB. :) > Is it safe to delete these files? Could you leave these? I'm actually working on updating these in: https://issues.apache.org/jira/browse/SAMZA-14 Cheers, Chris On Tue, Feb 3, 2015 at 5:17 AM, Ruslan Khafizov <ruslan.khafi...@gmail.com> wrote: > Hi All, > > I looked at newbie issues and SAMZA-435 Remove LevelDB support seamed > easy enough. > I removed samza-kv-leveldb and cleared dependencies in gradle. > > Unfortunately I couldn't submit review request - probably due to git > corruption. > I parked changes temporarily at > https://github.com/kharus/samza/tree/samza-435 > > I have two questions regarding this cleanup. > > 1) LevelDB mentioned several times in CachedStore scaladoc. At first I > wanted just replace it with RocksDB but while comment refers to > CachedStore as a "caching layer around the leveldb store" actually it > caches KeyValueStore which has several implementations. > I thought maybe CachedStore evolved since scaladoc has been written. > Can please anyone suggest what to do with LevelDB references in > CachedStore scaladoc. Can it be replaced by RocksDB or scaladoc has to > be re-written? > > 2) There are several files which refer to pre-apache > samza.storage.kv.KeyValueStorageEngineFactory > > samza-test/src/main/config/hello-stateful-world.samsa > samza-test/src/main/config/join/checker.samsa > samza-test/src/main/config/join/emitter.samsa > samza-test/src/main/config/join/joiner.samsa > samza-test/src/main/config/perf/counter.samsa > > I greped sources and they are not referred from other files. I deleted > them and gradle clean build passes. > Is it safe to delete these files? > > Regards, > Ruslan >
