----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32155/#review77245 -----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala <https://reviews.apache.org/r/32155/#comment125113> @Yan, I have two questions here: 1. When flush on one source failed, why are we trying to continue w/ other sources? Isn't it true that we will anyways re-try the whole flush again when the producer is re-created? 2. In the code block from 153, wouldn't it be easier to set a noFlushStop flag s.t. the stop() method can avoid calling the flush again when stop() is triggered from failed flush anyways? - Yi Pan (Data Infrastructure) On March 17, 2015, 9:37 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32155/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 9:37 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-458 > https://issues.apache.org/jira/browse/SAMZA-458 > > > Repository: samza > > > Description > ------- > > add flush in close method > only throw exceptions after flushing all sources > add unit test > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala > 83668dd > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala > ca10ea5 > > Diff: https://reviews.apache.org/r/32155/diff/ > > > Testing > ------- > > ran unit tests and integration test > > > Thanks, > > Yan Fang > >
