----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/#review80228 -----------------------------------------------------------
samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java <https://reviews.apache.org/r/33219/#comment130021> One quick question: do we need to implement all those rules? Or are we mainly re-using the rules implemented in Calcite? samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java <https://reviews.apache.org/r/33219/#comment130028> Add Java doc here. samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java <https://reviews.apache.org/r/33219/#comment130032> I assume that this class is used to convert the data schema/types in samza-sql-core model to Calcite's RelDataType? In that case, can we use the generic Schema class in samza-sql-core instead of implementation specific for Avro? - Yi Pan (Data Infrastructure) On April 15, 2015, 2:49 p.m., Milinda Pathirage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33219/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 2:49 p.m.) > > > Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-649 > https://issues.apache.org/jira/browse/SAMZA-649 > > > Repository: samza > > > Description > ------- > > Moved Calcite based front-end to samza-sql-calcite module. > > > Diffs > ----- > > build.gradle a1c7133 > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java > PRE-CREATION > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaCalciteConnection.java > PRE-CREATION > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaQueryPreparingStatement.java > PRE-CREATION > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java > PRE-CREATION > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java > PRE-CREATION > > samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/SamzaStreamTableFactory.java > PRE-CREATION > > samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/TestQueryPlanner.java > PRE-CREATION > > samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java > PRE-CREATION > > samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java > 3dad046 > samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java > 1dfb262 > > samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java > 63b1da5 > > samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java > 0721573 > > samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java > f46c1f0 > > samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java > 022116e > > samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java > f757d8f > > samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java > b4ac5f5 > settings.gradle 5cbb755 > > Diff: https://reviews.apache.org/r/33219/diff/ > > > Testing > ------- > > ./bin/check-all.sh passed. > > > Thanks, > > Milinda Pathirage > >
