----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35071/#review87507 -----------------------------------------------------------
Ship it! lgtm! - Navina Ramesh On June 4, 2015, 2:42 p.m., József Márton Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35071/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 2:42 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Fix for [SAMZA-572](https://issues.apache.org/jira/browse/SAMZA-572): > > In RunLoop commit() and window() are called immediately on startup. This > patch fixes the problem by setting the lastCommitMs and lastWindowMs to > clock() > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 4c0faf6 > samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala > 73ec2b5 > > Diff: https://reviews.apache.org/r/35071/diff/ > > > Testing > ------- > > Unit test added to verify that window() and commit() are not called > immediately on startup. > > > Thanks, > > József Márton Jung > >
