> On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 149 > > <https://reviews.apache.org/r/36815/diff/4/?file=1024086#file1024086line149> > > > > Quick question: Is it guaranteed that there is no DeleteResponse here? > > It would be good to at least log a warn if we get an unexpected response > > here. > > Roger Hoover wrote: > It is guaranteed that you will not get a DeleteResponse back because the > producer currently only allows IndexRequests. In the furture, if it supports > DeleteRequest then we should add a counter metric for deletes. > > Yi Pan (Data Infrastructure) wrote: > @Roger, thanks for the explanation. My point is: it would be good to make > the code detect and log unexpected response.
Oh, I see. I just added a warning log to do that. - Roger ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/#review93395 ----------------------------------------------------------- On July 29, 2015, 6:22 a.m., Roger Hoover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36815/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 6:22 a.m.) > > > Review request for samza and Dan Harvey. > > > Repository: samza > > > Description > ------- > > SAMZA-741 Add support for versioning to Elasticsearch System Producer > > > Diffs > ----- > > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java > f61bd36 > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java > e3b635b > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java > afe0eee > > samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetricsTest.java > 980964f > > samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java > 684d7f6 > > Diff: https://reviews.apache.org/r/36815/diff/ > > > Testing > ------- > > Refactored DefaultIndexRequestFactory to make it easier to subclass and > customize to handle version and version_type parameters. > > > Thanks, > > Roger Hoover > >
