----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37039/ -----------------------------------------------------------
(Updated Aug. 6, 2015, 8:11 a.m.) Review request for samza. Changes ------- Changed comments to javadoc style. Repository: samza Description ------- We are using InetAddress.getLocalHost().getHostAddress() for the org.apache.samza.coordinator.server.HttpServer#getUrl. But getLocalHost() may return a loopback address, 127.0.0.1, which is not reachable by other machines. Added a method to Util.scala which resolves the first network address which is not a loopback address. Diffs (updated) ----- samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java e3adc85 samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 27b2517 samza-core/src/main/scala/org/apache/samza/coordinator/server/HttpServer.scala dfe3a45 samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala de45123 samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala 6b7f0ba samza-core/src/main/scala/org/apache/samza/util/Util.scala 419452c samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala ead6f94 samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventJsonSerde.java cbf552c Diff: https://reviews.apache.org/r/37039/diff/ Testing ------- Thanks, József Márton Jung
