----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38614/#review99969 -----------------------------------------------------------
Ship it! Looks good to me. I hope you were able to test with a sample job. samza-kafka/src/main/scala/old/checkpoint/KafkaCheckpointManager.scala (line 81) <https://reviews.apache.org/r/38614/#comment157023> If the write* methods are used only in unit tests, should we consider moving it to TestKafkaCheckpointManager class? samza-kafka/src/test/scala/old/checkpoint/TestKafkaCheckpointManager.scala (line 307) <https://reviews.apache.org/r/38614/#comment157021> Remove unused commented line - Navina Ramesh On Sept. 22, 2015, 11 p.m., Yi Pan (Data Infrastructure) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38614/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 11 p.m.) > > > Review request for samza, Yan Fang and Navina Ramesh. > > > Bugs: SAMZA-615 > https://issues.apache.org/jira/browse/SAMZA-615 > > > Repository: samza > > > Description > ------- > > SAMZA-615: Add auto-checkpoint migration for Kafka checkpoints > > > Diffs > ----- > > build.gradle 3a7fabcd4f4e5c8db950c3a33bba33618c5565b4 > checkstyle/import-control.xml bc07ae8116c00aecf2ac2fa3da58985c5ebe9e11 > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java > 79291af64a83e59901de648ca2c81c8317235dc1 > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemProducer.java > 42ae00b3166b8adc8ad0ce102e1707d52946dc2e > > samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetMigrationMetaMessage.java > PRE-CREATION > samza-core/src/main/java/org/apache/samza/migration/MigrationPlan.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala > 16732179f8f3783a62b1bb4f34ce46da44a3140e > > samza-core/src/main/scala/org/apache/samza/migration/JobRunnerMigration.scala > PRE-CREATION > > samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamSystemFactory.java > 84ae0b5e3d35c6cabf7f712610d2118c8982bd1b > > samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamWrappedConsumer.java > 47a44b1df3f3abdc782ca1b29c520609265fd365 > samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java > 52d450d79cc1f87fe43dcd9ef06dbed4432fa919 > samza-core/src/test/resources/test-migration-fail.properties PRE-CREATION > samza-core/src/test/scala/org/apache/samza/job/TestJobRunner.scala > 52057edbbcd08b7d6edde7e898466d26534f52f6 > samza-kafka/src/main/scala/old/checkpoint/KafkaCheckpointLogKey.scala > PRE-CREATION > samza-kafka/src/main/scala/old/checkpoint/KafkaCheckpointManager.scala > PRE-CREATION > > samza-kafka/src/main/scala/old/checkpoint/KafkaCheckpointManagerFactory.scala > PRE-CREATION > samza-kafka/src/main/scala/old/checkpoint/KafkaCheckpointMigration.scala > PRE-CREATION > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala > c0c34bf887d3c0bc4beb8a06a1897a82bba0c654 > samza-kafka/src/test/scala/old/checkpoint/TestKafkaCheckpointManager.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/38614/diff/ > > > Testing > ------- > > ./bin/check-all.sh passed. > > > Thanks, > > Yi Pan (Data Infrastructure) > >
