----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40525/#review107320 -----------------------------------------------------------
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala (line 84) <https://reviews.apache.org/r/40525/#comment166391> To make sure that it is flush() that write to the disk, not close(), you may want to keep this db open and open another db in read-only mode to verify that the read-only db sees the data. - Yi Pan (Data Infrastructure) On Nov. 20, 2015, 6:18 a.m., tao feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40525/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 6:18 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > 1. implement RocksDB flush method; > 2. RocksDB flushOptions waitForFlush set to true; > 3. unit test > > > Diffs > ----- > > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala > b949793a63951576937fa848bd674ec68f6f9727 > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > 4620037f2a0da43149a754aa808d3d5d280ea893 > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala > a428a16bc1e9ab4980a6f17db4fd810057d31136 > > Diff: https://reviews.apache.org/r/40525/diff/ > > > Testing > ------- > > 1. ./gradlew clean build > 2. ./gradlew checkstyleMain checkstyleTest > > > Thanks, > > tao feng > >
