----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44241/#review121736 -----------------------------------------------------------
Ship it! Looks like this debug->info conversions are mainly for container allocations. So it should not add too much noise and should be quite helpfull. - Boris Shkolnik On March 2, 2016, 2:24 a.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44241/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 2:24 a.m.) > > > Review request for samza, Jagadish Venkatraman and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > SAMZA-883 Improve logging for container handling and kafka refresh > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala > 9aa98184f8ab186eff226482f894e8842b9525e5 > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala > b37375360bcad8e3333089d95e8e3da63a1b9aab > > samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala > 0f91622c0c4c270a376f8b91b3e785cca57bc9dd > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java > 54db5e5b2b1b109d202e814809adbfd2bc84fb4b > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerUtil.java > 91fae98c074e1648e7168fb8e76d6e1e656816fc > > Diff: https://reviews.apache.org/r/44241/diff/ > > > Testing > ------- > > Manual testing and log verification (made sure they weren't verbose) > > > In case there is some concern over the messages I switched from debug to > info. I let a job run for 4 hours: > NUM_OCCURRENCES | Message | Notes > 2 | "ClientUtilTopicMetadataStore [INFO] Fetching topic metadata." | Same > occurrences as the ClientUtil INFO log message from Kafka > 33 | "ContainerRequestState [INFO] Got a new container: ..." | Approx equal > to the number of containers in the normal case. All other logs updated in > ContainerRequestState will be of similar or lower frequency. > > > Thanks, > > Jake Maes > >
