----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44772/ -----------------------------------------------------------
Review request for samza, Navina Ramesh and Jagadish Venkatraman. Repository: samza Description ------- SAMZA-893 Fix the host affinity expiration logic bug introduced in SAMZA-867 and fix the tests Diffs ----- samza-yarn/src/main/java/org/apache/samza/job/yarn/HostAwareContainerAllocator.java 979719687be864bf24354aea0a7dc51b5f11a712 samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java 2b1bdab3c8de3184e930c244a8cae55813c33565 samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java 0c7a09f3e4c4c2ce6788be729d0bf4a294243c68 samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerListener.java cb82cccf75b54cfbefd586700e8283cb41173833 samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerRequestState.java 879a7d0d06b087cfe0417f3fa5801b43ac7fc458 samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerUtil.java 2f9669f8b7e77abb65b244ccd067ae7ab1f245c3 Diff: https://reviews.apache.org/r/44772/diff/ Testing ------- Verified that the tests fail without the logic fix and pass with it. I think I fixed some of the sporadic failures in the tests too. Ran them many times to confirm. Thanks, Jake Maes