----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45387/#review125681 -----------------------------------------------------------
Ship it! LGTM.. Please could you fill-in the testing done section? I'm assuming the hello-world runs with the expected log output. Thanks! - J - Jagadish Venkatraman On March 28, 2016, 4:36 p.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45387/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 4:36 p.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > Add milliseconds and thread name to log4j config > > > Diffs > ----- > > src/main/resources/log4j.xml 129149ffe84c9605d929deb8edec553955535c34 > > Diff: https://reviews.apache.org/r/45387/diff/ > > > Testing > ------- > > > Thanks, > > Jake Maes > >
