----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/ -----------------------------------------------------------
(Updated June 9, 2016, 7:49 p.m.) Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure). Changes ------- Fixed a bug in AsyncTaskWorder.process. Prevoiusly we are generating the callback here before calling taskInstance.process(). Actually taskInstance.process() has some ssp caughtup check so might not call task.process(). So instead of passing in the callback, I pass in a callback factory to generate the callback only when task.process is called. Other updates are based on Chris's feedback. Repository: samza Description ------- This is the main part of the change, including the following: - New API for AsyncStreamTask and callback. - Multithread scheduling in AsyncRunLoop - Callback management for asyn tasks Diffs (updated) ----- checkstyle/import-control.xml 7a09c7ed8ab372d2342f31e850ae09c605292eb2 samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 3f25eca6e3dffc57360e8bd8c435177c2a9a910a samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala cf3c4c0ab08a59760bc899c6f2027755e933b350 samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 9e6641c3628290dc05e1eb5537e86bff9d37f92c samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00 samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58 samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86 samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78 samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b Diff: https://reviews.apache.org/r/48243/diff/ Testing ------- unit tests and local testing. Thanks, Xinyu Liu
