----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50588/#review144045 -----------------------------------------------------------
Ship it! Ship It! - Jake Maes On July 29, 2016, 12:13 a.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50588/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 12:13 a.m.) > > > Review request for samza, Jake Maes, Navina Ramesh, and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > During the process of making offsetManager thread-safe, I changed the impl of > lastProcessedOffsets to use ConcurrentHashMap. However, I didn't realize > offset can be null so it will trigger null pointer exception when > ConcurrentHashMap.put(key, null). The fix will add the null check so null > offset will be still supported such as in our hello-samza example. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala > 7245902c69c751a4e8853745de46adf5553d45f5 > > samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala > 75ba8af7cdda6b297abaa3dbb99c98b406e31f88 > > Diff: https://reviews.apache.org/r/50588/diff/ > > > Testing > ------- > > tested by unit tests and verifed also in hello-samza jobs. > > > Thanks, > > Xinyu Liu > >
