----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51047/#review145916 -----------------------------------------------------------
docs/startup/hello-samza/versioned/index.md (line 52) <https://reviews.apache.org/r/51047/#comment212272> We will still need to checkout latest hello-samza, if the instruction here does not include how to modify the pom.xml and the build.gradle files to point to the new SNAPSHOT version built from the master branch of samza repo. And if we do that, there actually is no reason to keep the latest branch in hello-samza, which may be a bigger scope of work. I would rather work on integrate hello-samza into the same repository as samza (SAMZA-205) So, weighing all the options, would it be better if we keep the latest version of hello-samza documentation include the checkout latest and make this publishToMavenLocal as mandatory, while removing both the checkout latest and the publishToMavenLocal in the released version of document? - Yi Pan (Data Infrastructure) On Aug. 15, 2016, 6:18 p.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51047/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 6:18 p.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, > Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data > Infrastructure). > > > Bugs: SAMZA-1000 > https://issues.apache.org/jira/browse/SAMZA-1000 > > > Repository: samza > > > Description > ------- > > SAMZA-1000 Fix hello-samza documentation to not use latest branch by default > > > Diffs > ----- > > docs/startup/hello-samza/versioned/index.md > 8baacd390d41c5c87a426d63eec9ce5028de0cc2 > gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf > > Diff: https://reviews.apache.org/r/51047/diff/ > > > Testing > ------- > > > Thanks, > > Jake Maes > >
