> On Sept. 1, 2016, 1:50 a.m., Navina Ramesh wrote: > > Overall, the patch looks pretty good! The only roadblock I see is that with > > SAMZA-680, we introduced "ContainerProcessManagerMetrics" which would > > replace "SamzaAppMasterMetrics". This is kind of problematic because it > > seems to expose 2 copies of essentially the same metrics - under different > > "groups" or "class names". I am not sure why we have 2 copies of the same > > metric? > > @vjagadish : why do we have 2 copies of these metrics? What is the plan > > going forward? > > > > Otherwise, +1 for this patch. Thanks a lot!
We have discussed this extensively in the past and have concluded that we'll deprecate SamzaAppMasterMetrics in a subsequent release. The release notes of the upcoming release will call it out. - Jagadish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51516/#review147523 ----------------------------------------------------------- On Aug. 30, 2016, 7:36 a.m., Branislav Cogic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51516/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 7:36 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-702 > https://issues.apache.org/jira/browse/SAMZA-702 > > > Repository: samza > > > Description > ------- > > All the metrics documented in a metrics-table. > > Few counters and timer removed because they are not used: > "send-calls" counter and "chooser-update-ns" timer from SamzaContainerMetrics > "batch-resets" counter from BootstrapingChooserMetrics > > > Diffs > ----- > > docs/_layouts/default.html 7beb734ddeaecb7a6369f7d2a5d4e0c67655269c > docs/learn/documentation/versioned/container/metrics-table.html > PRE-CREATION > docs/learn/documentation/versioned/container/metrics.md > b053b792097400536ea385cb3db720f6f71da017 > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > 1e7515e8e8eb5ff2f769bea3184ce49308bada9a > > samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala > 1cd8e0637e2192460a9e9fe078c735444be8eb97 > > Diff: https://reviews.apache.org/r/51516/diff/ > > > Testing > ------- > > Site ran locally using local-site-test.sh > > > Thanks, > > Branislav Cogic > >
